Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add su2 adapter tests and update reference results #521

Merged
merged 23 commits into from
Apr 16, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Apr 12, 2024

Adds an SU2 component and tests using the SU2 adapter.

@valentin-seitz somehow this gives me empty logs (stdout.log, stderr.log) after running for a long time. Any clue why?

I know that at least the meson build step in the Dockerfile is running, and I think it probably gets stuck in the ninja install.

See this run: https://github.com/precice/tutorials/actions/runs/8665208853

Reproduce the run:

gh workflow run run_testsuite_manual.yml -f suites=su2_test -f systests_branch=add-su2-adapter-tests -f loglevel=DEBUG -f build_args="PRECICE_REF:v3.1.1,OPENFOAM_ADAPTER_REF:v1.3.0,PYTHON_BINDINGS_REF:v3.1.0,FENICS_ADAPTER_REF:v2.1.0,TUTORIALS_REF:45650f2" --ref=add-su2-adapter-tests

Reproduce locally:

python3 systemtests.py --suites=su2_test --log-level=DEBUG --build_args="PRECICE_REF:v3.1.1,OPENFOAM_ADAPTER_REF:v1.3.0,PYTHON_BINDINGS_REF:v3.1.0,FENICS_ADAPTER_REF:v2.1.0,TUTORIALS_REF:45650f2"

@MakisH MakisH self-assigned this Apr 12, 2024
@MakisH
Copy link
Member Author

MakisH commented Apr 12, 2024

Note that I don't always get empty logs. In previous states of debugging, I was getting output. I think that, whenever it is building the adapter, the log gets too long or something similar. But even when I build based on the cached layer (that's why I split the meson build and the ninja install), I get no output.

@MakisH
Copy link
Member Author

MakisH commented Apr 12, 2024

Or maybe the Docker layers were cached, so nothing was printed in the stdout.log, but somehow the running did not print any logs.

@MakisH
Copy link
Member Author

MakisH commented Apr 12, 2024

It is actually failing in the build step, due to dependencies (e.g., mpi4py).
Logging continues to be a puzzle: sometimes the stdout.log has content, sometimes not (but at the moment mostly not).

@MakisH
Copy link
Member Author

MakisH commented Apr 12, 2024

New observation: This run actually completed the build step, and failed in the beginning of the run step. No stdout.log was written at all (not an empty file; just no file at all), while we got simulation logs.

@MakisH MakisH changed the title Add su2 adapter tests Add su2 adapter tests and update reference results Apr 13, 2024
@MakisH
Copy link
Member Author

MakisH commented Apr 13, 2024

The system tests now succeed: https://github.com/precice/tutorials/actions/runs/8672889794/job/23783659705

I have updated all reference results in this PR as well (we cannot only update reference results for specific tests with the current workflow).

I also needed to increase the global timeout, as the SU2-FeniCS test currently takes 8min.

@valentin-seitz could you please have a quick sanity check? Have I forgotten anything? Have I misused anything?

Regarding the logging issue, let's postpone and offload it here: #522

@valentin-seitz
Copy link
Member

valentin-seitz commented Apr 16, 2024

The system tests now succeed: https://github.com/precice/tutorials/actions/runs/8672889794/job/23783659705

I have updated all reference results in this PR as well (we cannot only update reference results for specific tests with the current workflow).

I also needed to increase the global timeout, as the SU2-FeniCS test currently takes 8min.

@valentin-seitz could you please have a quick sanity check? Have I forgotten anything? Have I misused anything?

Regarding the logging issue, let's postpone and offload it here: #522

I think we discussed most of it already via phone.
We should most definitely have a look into the spurious logging behavior and maybe document the possibilty of the docker compose --file docker-compose.tutorials.yaml up thing somewhere in the cli.
The last safeguard is the adding of the reference results. Here the pipeline should not fail. Which it did not, so 👍

@MakisH MakisH merged commit 65c30d1 into develop Apr 16, 2024
1 check passed
@MakisH MakisH deleted the add-su2-adapter-tests branch April 16, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants